cephadm: fix logging defaults #32641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is the stderr saved somewhere if the daemon crashes or otherwise stops? |
|
IIUC it goes to journald. something like
journalctl -u ceph-$fsid-$type.$id
to view?
|
confirmed |
mgfritch
requested changes
Jan 15, 2020
liewegas
force-pushed
the
wip-cephadm-log
branch
from
df3e1ce
to
437ab56
Compare
Also confirmed using: |
liewegas
force-pushed
the
wip-cephadm-log
branch
from
437ab56
to
2adb2a1
Compare
jdurgin
approved these changes
Jan 15, 2020
|
Perhaps This would allow for access to logs even when the container is stopped/crashed: |
- prefix stderr log lines with 'debug ' - send cluster log to stderr (only affects mons) - default to sending cluser log to stderr only (not to file) This aligns things with the container-y way, as we do with rook. It means that if you want legacy behavior (log files), you have *2* settings to change: log_to_file = true mon_cluster_log_to_file = true We could default this to leave cluster log to file by default since they aren't that big (and we do have log rotation), but it's not as clean as it could be... Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-cephadm-log
branch
from
2adb2a1
to
d073591
Compare
liewegas
added a commit
that referenced
this pull request
Jan 18, 2020
* refs/pull/32641/head: cephadm: fix logging defaults Reviewed-by: Michael Fritch <mfritch@suse.com> Reviewed-by: Josh Durgin <jdurgin@redhat.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns things with the container-y way, as we do
with rook. It means that if you want legacy behavior (log files),
you have 2 settings to change:
log_to_file = true
mon_cluster_log_to_file = true
We could default this to leave cluster log to file by default
since they aren't that big (and we do have log rotation), but
it's not as clean as it could be...
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox